[webkit-changes] [WebKit/WebKit] 20ba73: Avoid crashing if traverseUnchangedSubtree can't f...

mattwoodrow noreply at github.com
Thu Jul 18 15:55:37 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 20ba7372309cd112039c97c47a566e80de1aefe8
      https://github.com/WebKit/WebKit/commit/20ba7372309cd112039c97c47a566e80de1aefe8
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-07-18 (Thu, 18 Jul 2024)

  Changed paths:
    M Source/WebCore/rendering/RenderLayerCompositor.cpp

  Log Message:
  -----------
  Avoid crashing if traverseUnchangedSubtree can't find the same backingSharingProvider.
https://bugs.webkit.org/show_bug.cgi?id=276754
<rdar://131972979>

Reviewed by Simon Fraser.

This currently is a nullptr crash if backingProviderCandidateForLayer returns
nullptr.

We should be able to see if the candidate used from the last update is still
available, and use that to avoid the crash (but still render incorrectly).

* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::BackingSharingState::previousBackingProviderCandidateForLayer):
(WebCore::RenderLayerCompositor::traverseUnchangedSubtree):

Canonical link: https://commits.webkit.org/281112@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list