[webkit-changes] [WebKit/WebKit] 64b7f8: [Viewer Mode] subtitles duplicate when activated w...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 64b7f879fb0305895b2b0921c11a00714469bf0d
      https://github.com/WebKit/WebKit/commit/64b7f879fb0305895b2b0921c11a00714469bf0d
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2024-07-18 (Thu, 18 Jul 2024)

  Changed paths:
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.h
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl
    M Source/WebCore/Modules/modern-media-controls/media/media-controller.js

  Log Message:
  -----------
  [Viewer Mode] subtitles duplicate when activated within Viewer Mode and native media player
https://bugs.webkit.org/show_bug.cgi?id=276724
rdar://126659995

Reviewed by Eric Carlson.

When selecting a new text track from within InWindowFullscreen mode, remember the previously
selected text track (including the "off" and "auto" options), and restore that selection when
exiting InWindowFullscreen mode.

* Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::showMediaControlsContextMenu):
(WebCore::MediaControlsHost::presentationModeChanged):
(WebCore::MediaControlsHost::savePreviouslySelectedTextTrackIfNecessary):
(WebCore::MediaControlsHost::restorePreviouslySelectedTextTrackIfNecessary):
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.h:
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl:
* Source/WebCore/Modules/modern-media-controls/media/media-controller.js:
(MediaController.prototype.handleEvent):

Canonical link: https://commits.webkit.org/281109@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications