[webkit-changes] [WebKit/WebKit] 6eef85: errorValidatingDynamicOffsets can be bypassed in s...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6eef85d192a8f02fa74fc620854c83dd0fff6fed
      https://github.com/WebKit/WebKit/commit/6eef85d192a8f02fa74fc620854c83dd0fff6fed
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-07-17 (Wed, 17 Jul 2024)

  Changed paths:
    M Source/WebGPU/WebGPU/ComputePassEncoder.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  -----------
  errorValidatingDynamicOffsets can be bypassed in setBindGroup
https://bugs.webkit.org/show_bug.cgi?id=276617
<radar://131764000>

Reviewed by Tadeu Zagallo.

We should call remove on the dynamic offsets when one
does not exist, otherwise the behavior of a draw call may
not be what is expected. We may honor the draw call, when
it should have been rejected by validation.

* Source/WebGPU/WebGPU/ComputePassEncoder.mm:
(WebGPU::ComputePassEncoder::setBindGroup):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::setBindGroup):

Canonical link: https://commits.webkit.org/281055@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications