[webkit-changes] [WebKit/WebKit] f087a1: [JSC] InById / InByVal should reset SP too in Base...

Yusuke Suzuki noreply at github.com
Tue Jul 16 16:04:54 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f087a1892ee65f63fc511d500f59c8ecd31b7e0b
      https://github.com/WebKit/WebKit/commit/f087a1892ee65f63fc511d500f59c8ecd31b7e0b
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-07-16 (Tue, 16 Jul 2024)

  Changed paths:
    M Source/JavaScriptCore/jit/JITPropertyAccess.cpp

  Log Message:
  -----------
  [JSC] InById / InByVal should reset SP too in Baseline
https://bugs.webkit.org/show_bug.cgi?id=276688
rdar://131869701

Reviewed by Keith Miller.

Now InById / InByVal can call ProxyObject handlers and they get inlined in DFG.
Thus we should adjust stack pointer after the calls as the same to GetById / GetByVal.

* Source/JavaScriptCore/jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_in_by_id):
(JSC::JIT::emit_op_in_by_val):
(JSC::JIT::emitHasPrivate):

Canonical link: https://commits.webkit.org/281024@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list