[webkit-changes] [WebKit/WebKit] 03200a: Crash in WebViewRenderingUpdateScheduler::postRend...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 03200a8c08079e188c3de7a97109a51202cc6c64
      https://github.com/WebKit/WebKit/commit/03200a8c08079e188c3de7a97109a51202cc6c64
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2024-07-15 (Mon, 15 Jul 2024)

  Changed paths:
    M Source/WebKitLegacy/mac/WebView/WebViewRenderingUpdateScheduler.h
    M Source/WebKitLegacy/mac/WebView/WebViewRenderingUpdateScheduler.mm

  Log Message:
  -----------
  Crash in WebViewRenderingUpdateScheduler::postRenderingUpdateCallback
https://bugs.webkit.org/show_bug.cgi?id=276620

Reviewed by Chris Dumez and Wenson Hsieh.

Speculative fix. Use WeakPtr and CheckedPtr to better life-time manage WebViewRenderingUpdateScheduler,
and grab the web thread lock before converting WeakPtr to CheckedPtr.

* Source/WebKitLegacy/mac/WebView/WebViewRenderingUpdateScheduler.h:
* Source/WebKitLegacy/mac/WebView/WebViewRenderingUpdateScheduler.mm:
(WebViewRenderingUpdateScheduler::WebViewRenderingUpdateScheduler):
(WebViewRenderingUpdateScheduler::invalidate):
(WebViewRenderingUpdateScheduler::renderingUpdateRunLoopObserverCallback):
(WebViewRenderingUpdateScheduler::postRenderingUpdateCallback):

Canonical link: https://commits.webkit.org/280989@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications