[webkit-changes] [WebKit/WebKit] 55b960: Unreviewed, revert 273841 at main partially, which is...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 55b96047c0a66e4042c20748d611c9c3d3a003e3
      https://github.com/WebKit/WebKit/commit/55b96047c0a66e4042c20748d611c9c3d3a003e3
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-07-15 (Mon, 15 Jul 2024)

  Changed paths:
    M Source/JavaScriptCore/runtime/JSCJSValue.h
    M Source/JavaScriptCore/runtime/WriteBarrier.h

  Log Message:
  -----------
  Unreviewed, revert 273841 at main partially, which is regressing 64bit implementation
https://bugs.webkit.org/show_bug.cgi?id=276603
rdar://131741850

The patch added const volatile for all WriteBarrier::get in 64bit, which is completely wrong since it avoids any CSE for loads.
This immediately reverts that.

* Source/JavaScriptCore/runtime/JSCJSValue.h:
(JSC::JSValue::decodeConcurrent):
(JSC::updateEncodedJSValueConcurrent):
(JSC::clearEncodedJSValueConcurrent):
* Source/JavaScriptCore/runtime/WriteBarrier.h:

Canonical link: https://commits.webkit.org/280965@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications