[webkit-changes] [WebKit/WebKit] 6036a9: [watchOS] Quickboard input view controller should ...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6036a9fa2afb795686f91c6cfd379b72d032d549
      https://github.com/WebKit/WebKit/commit/6036a9fa2afb795686f91c6cfd379b72d032d549
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-07-12 (Fri, 12 Jul 2024)

  Changed paths:
    M LayoutTests/fast/forms/watchos/form-control-label-text-expected.txt
    M LayoutTests/fast/forms/watchos/form-control-label-text.html
    M Source/WebCore/en.lproj/Localizable.strings
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  -----------
  [watchOS] Quickboard input view controller should have non-empty fallback text for unlabeled text fields
https://bugs.webkit.org/show_bug.cgi?id=276550
rdar://125570089

Reviewed by Wenson Hsieh.

For certain text input fields, Quickboard input view controller presents
a button that the user must press before entering scribble mode. In the
absence of any AX labels or placeholder text, a user is simply presented
with a blank button, which is not very intuitive.

In this patch, we fix this confusing UX by enforcing some non-empty
fallback text in the Quickboard input view controller. We condition this
fallback text based on the focused element's input mode, and in case
that is unspecified, we consult the element type to infer an appropriate
input mode.

* LayoutTests/fast/forms/watchos/form-control-label-text-expected.txt:
* LayoutTests/fast/forms/watchos/form-control-label-text.html:
* Source/WebCore/en.lproj/Localizable.strings:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(fallbackLabelTextForUnlabeledInputFieldInZoomedFormControls):
(-[WKContentView inputLabelText]):

Canonical link: https://commits.webkit.org/280933@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications