[webkit-changes] [WebKit/WebKit] 19ad27: WritingTools tests are failing/crashing on mac deb...

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 19ad276d70970698f0dcfcf1bbec8d65ff8b59af
      https://github.com/WebKit/WebKit/commit/19ad276d70970698f0dcfcf1bbec8d65ff8b59af
  Author: Megan Gardner <megan_gardner at apple.com>
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm

  Log Message:
  -----------
  WritingTools tests are failing/crashing on mac debug builds.
https://bugs.webkit.org/show_bug.cgi?id=276405
rdar://131429390

Reviewed by Richard Robinson.

We need to wait a bit longer than a presentation update to let the animations
run long enough for the test to be replaced, so that the next call is
operating on the correct ranges.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm:
(TEST(WritingTools, ProofreadingWithStreamingSuggestions)):
(TEST(WritingTools, ProofreadingWithAttemptedEditing)):
(TEST(WritingTools, CompositionWithAttemptedEditing)):
(TEST(WritingTools, CompositionWithUndoAfterEnding)):
(TEST(WritingTools, CompositionWithUndo)):
(TEST(WritingTools, CompositionWithMultipleUndosAndRestarts)):
(TEST(WritingTools, CompositionWithUndoAndRestart)):
(TEST(WritingTools, CompositionWithAttributedStringAttributes)):
(TEST(WritingTools, CompositionWithImageRoundTrip)):
(TEST(WritingTools, CompositionWithNonImageAttachmentRoundTrip)):
(TEST(WritingTools, CompositionWithSystemFont)):
(TEST(WritingTools, CompositionWithMultipleChunks)):
(TEST(WritingTools, CompositionWithTrailingNewlines)):
(TEST(WritingTools, CompositionWithTrailingBreaks)):
(TEST(WritingTools, SmartRepliesMatchStyle)):
(TEST(WritingTools, ContextRangeFromCaretSelection)):
(TEST(WritingTools, ContextRangeFromRangeSelection)):
(TEST(WritingTools, SuggestedTextIsSelectedAfterSmartReply)):

Canonical link: https://commits.webkit.org/280870@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications