[webkit-changes] [WebKit/WebKit] 3f2972: [GStreamer] Move gstStructureGet<T> definition to ...

[Carlos Bentzen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3f2972a007a277a88260b3a433e500fdf9d62e6e
      https://github.com/WebKit/WebKit/commit/3f2972a007a277a88260b3a433e500fdf9d62e6e
  Author: Carlos Bentzen <cadubentzen at igalia.com>
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
    M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h

  Log Message:
  -----------
  [GStreamer] Move gstStructureGet<T> definition to cpp file
https://bugs.webkit.org/show_bug.cgi?id=276484

Reviewed by Xabier Rodriguez-Calvar and Philippe Normand.

Move gstStructureGet<T>'s definition to the cpp file, because it improves
recompilation times when adding new types.

Driving by, since the function isn't inlined anymore, we don't hit
the miscompilation bug with Clang 18 bug fixed by 280669 at main anymore, so
we can remove the workaround with UNLIKELY.

* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::gstStructureGet):
* Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:
(WebCore::gstStructureGet): Deleted.

Canonical link: https://commits.webkit.org/280859@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications