[webkit-changes] [WebKit/WebKit] 8a053f: Clicking and dragging video viewer drags a layer ...

Dana Estra noreply at github.com
Wed Jul 10 16:00:51 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8a053f41c96e04f9c7747d6fad34251896c44542
      https://github.com/WebKit/WebKit/commit/8a053f41c96e04f9c7747d6fad34251896c44542
  Author: Dana Estra <destra at apple.com>
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
    M Source/WebCore/Modules/modern-media-controls/media/media-controller.js

  Log Message:
  -----------
  Clicking and dragging  video viewer drags a layer on top of the other
https://bugs.webkit.org/show_bug.cgi?id=276400
rdar://127512495

Reviewed by Jer Noble and Antoine Quint.

On YouTube.com, clicking and dragging on a video in Video Viewer causes elements on
the page behind the video to come to the forefront. This is because YouTube gives
a draggable=true attribute to the parent div of the video element.

To fix this, now when we enter fullscreen on macOS, we add a dragstart event listener
to the window, which calls preventDefault() when the dragstart event occurs. We
remove this event listener when we enter inline.

* Source/WebCore/Modules/modern-media-controls/media/media-controller.js:
(MediaController.prototype.handleEvent):
(MediaController.prototype._updateControlsIfNeeded):

Canonical link: https://commits.webkit.org/280838@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list