[webkit-changes] [WebKit/WebKit] 971540: REGRESSION (280542 at main): Unable to select text af...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 97154054bc3972ec909071838bba2c7cca25db47
      https://github.com/WebKit/WebKit/commit/97154054bc3972ec909071838bba2c7cca25db47
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
    M Source/WebCore/editing/cocoa/HTMLConverter.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm

  Log Message:
  -----------
  REGRESSION (280542 at main): Unable to select text after using Writing Tools to summarize
https://bugs.webkit.org/show_bug.cgi?id=276372
rdar://131388499

Reviewed by Richard Robinson.

280542 at main introduced a Web Content hang when generating attributed strings
for Writing Tools, due to the use of `HashMap::ensure` with a recursive method.

Fix by using `HashMap::contains` instead.

* Source/WebCore/editing/cocoa/HTMLConverter.mm:
(hasAncestorQualifyingForWritingToolsPreservation):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm:
(TEST(WritingTools, EphemeralSessionWithDeeplyNestedContent)):

Canonical link: https://commits.webkit.org/280792@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications