[webkit-changes] [WebKit/WebKit] dc84c8: nw_resolver object is getting leaked in DNSResolve...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dc84c8313fa72cc6280da47971fe6a9c2248f649
      https://github.com/WebKit/WebKit/commit/dc84c8313fa72cc6280da47971fe6a9c2248f649
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
    M Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h
    M Source/WebCore/platform/network/cf/DNSResolveQueueCFNet.cpp

  Log Message:
  -----------
  nw_resolver object is getting leaked in DNSResolveQueueCFNet::performDNSLookup()
https://bugs.webkit.org/show_bug.cgi?id=276348
rdar://129599341

Reviewed by Ben Nham.

In performDNSLookup(), we call `nw_resolver_set_update_handler()` and pass it the nw_resolver.
This call will retain the nw_resolver until `nw_resolver_cancel()` is called on the resolver.
However, we were never calling `nw_resolver_cancel()` and the resolver was thus leaking.

* Source/WebCore/platform/network/cf/DNSResolveQueueCFNet.cpp:
(WebCore::DNSResolveQueueCFNet::performDNSLookup):

Canonical link: https://commits.webkit.org/280775@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications