[webkit-changes] [WebKit/WebKit] df1a1c: Support border/margin/padding on msub/msup/msubsup

[Frédéric Wang]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: df1a1c2be0c95f797e04301be8b8471af5176537
      https://github.com/WebKit/WebKit/commit/df1a1c2be0c95f797e04301be8b8471af5176537
  Author: Frédéric Wang <fwang at igalia.com>
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-002-expected.txt
    R LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt
    M LayoutTests/platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-002-expected.txt
    M LayoutTests/platform/ios/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-002-expected.txt
    M LayoutTests/platform/mac/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-002-expected.txt
    M Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp

  Log Message:
  -----------
  Support border/margin/padding on msub/msup/msubsup
https://bugs.webkit.org/show_bug.cgi?id=276314

Reviewed by Rob Buis.

This implements support for border/margin/padding on the msub, msup
and msubsup elements according to the rules from MathML Core:

- When handling boxes of children during math layout, we consider *margin*
  boxes. `recomputeLogicalWidth()` is already called during the layout
  of children to set the inline margins (this does not seem enough for
  preferred width calculations though, but will be considered in
  follow-up patches). This patchs adds a logic to call
  `computeAndSetBlockDirectionMargins()` on each child in order to set
  their block margins.

- Current math layout is modified so that padding/border are added around
  the current layout in order to obtain the border box.

Canonical link: https://commits.webkit.org/280768@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications