[webkit-changes] [WebKit/WebKit] 2ea416: Fetch padding via a single virtual function call

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2ea416db59ab6baf93c482ed01d3ee8d14a66247
      https://github.com/WebKit/WebKit/commit/2ea416db59ab6baf93c482ed01d3ee8d14a66247
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-07-08 (Mon, 08 Jul 2024)

  Changed paths:
    M Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp
    M Source/WebCore/rendering/BackgroundPainter.cpp
    M Source/WebCore/rendering/RenderBoxInlines.h
    M Source/WebCore/rendering/RenderBoxModelObject.cpp
    M Source/WebCore/rendering/RenderBoxModelObject.h
    M Source/WebCore/rendering/RenderBoxModelObjectInlines.h
    M Source/WebCore/rendering/RenderLayerBacking.cpp
    M Source/WebCore/rendering/RenderReplaced.cpp
    M Source/WebCore/rendering/RenderReplaced.h
    M Source/WebCore/rendering/RenderTableCell.cpp
    M Source/WebCore/rendering/RenderTableCell.h
    M Source/WebCore/rendering/RenderWidget.cpp
    M Source/WebCore/rendering/shapes/BoxShape.cpp

  Log Message:
  -----------
  Fetch padding via a single virtual function call
https://bugs.webkit.org/show_bug.cgi?id=276335
rdar://131329205

Reviewed by Alan Baradlay.

As we did for borderWidths in 277679 at main, fix code that makes 4 virtual functions calls
for padding edges to use a single call that returns a RectEdges<>.

A common call pattern was via `getRoundedInnerBorderFor()`, which can be refactored to
move `RenderReplaced::roundedContentBoxRect()` down to `RenderBoxModelObject`, with
the caller passing the rectangle.

This slightly reduces the time under `RenderBox::contentBoxRect()` in benchmarks.

* Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
(WebCore::LayoutIntegration::flexBoxLogicalPadding):
* Source/WebCore/rendering/BackgroundPainter.cpp:
(WebCore::BackgroundPainter::paintFillLayer):
* Source/WebCore/rendering/RenderBoxInlines.h:
(WebCore::RenderBox::contentBoxRect const):
* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::roundedContentBoxRect const):
* Source/WebCore/rendering/RenderBoxModelObject.h:
* Source/WebCore/rendering/RenderBoxModelObjectInlines.h:
(WebCore::RenderBoxModelObject::padding const):
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateContentsRects):
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
* Source/WebCore/rendering/RenderReplaced.h:
* Source/WebCore/rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::padding const):
* Source/WebCore/rendering/RenderTableCell.h:
* Source/WebCore/rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):
* Source/WebCore/rendering/shapes/BoxShape.cpp:
(WebCore::computeRoundedRectForBoxShape):

Canonical link: https://commits.webkit.org/280759@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications