[webkit-changes] [WebKit/WebKit] ccf89c: [macOS] Avoid extraneous respondsToSelector call f...

Brent Fulgham noreply at github.com
Mon Jul 8 15:30:37 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ccf89c99d98bc6dfb9fc540469e7a475e9d7c0d1
      https://github.com/WebKit/WebKit/commit/ccf89c99d98bc6dfb9fc540469e7a475e9d7c0d1
  Author: Brent Fulgham <bfulgham at apple.com>
  Date:   2024-07-08 (Mon, 08 Jul 2024)

  Changed paths:
    M Source/WebKit/UIProcess/mac/ServicesController.mm

  Log Message:
  -----------
  [macOS] Avoid extraneous respondsToSelector call for sharing feature shipping since before macOS 11
https://bugs.webkit.org/show_bug.cgi?id=276211
<rdar://problem/131085950>

Reviewed by Aditya Keerthi.

We perform a selector check on every call to NSSharingService for
`getSharingServicesForItems:mask:completion:`, even though this method has been part of
NSSharingService since before macOS 11 (two releases before our lowest target OS).

We should avoid this unnecessary call.

* Source/WebKit/UIProcess/mac/ServicesController.mm:
(WebKit::hasCompatibleServicesForItems):

Canonical link: https://commits.webkit.org/280756@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list