[webkit-changes] [WebKit/WebKit] 5deb5d: REGRESSION (280396 at main): Web process receives une...

Sihui noreply at github.com
Sun Jul 7 13:13:43 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5deb5d7b1324d9891d34e4060c07f0bc27bca915
      https://github.com/WebKit/WebKit/commit/5deb5d7b1324d9891d34e4060c07f0bc27bca915
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-07-07 (Sun, 07 Jul 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxyTesting.cpp
    M Source/WebKit/UIProcess/WebPageProxyTesting.h

  Log Message:
  -----------
  REGRESSION (280396 at main): Web process receives unexpected message WebPageTesting::ClearWheelEventTestMonitor when running tests
https://bugs.webkit.org/show_bug.cgi?id=276269
rdar://131191681

Reviewed by Charlie Wolfe.

WebPageProxy can change its m_legacyMainFrameProcess and internals().webPageID (i.e. webPageIDInMainFrameProcess()) in
WebPageProxy::swapToProvisionalPage. Currently WebPageProxyTesting sends message to the latest web process of
WebPageProxy, but it uses an old page identifier captured at WebPageProxyTesting's creation time, so the web process may
not recognize the message.

* Source/WebKit/UIProcess/WebPageProxyTesting.cpp:
(WebKit::WebPageProxyTesting::WebPageProxyTesting):
(WebKit::WebPageProxyTesting::messageSenderDestinationID const):
* Source/WebKit/UIProcess/WebPageProxyTesting.h:

Canonical link: https://commits.webkit.org/280720@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list