[webkit-changes] [WebKit/WebKit] d4bb9d: [svg] WPT test `svg/path/property/test_style_flush...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d4bb9d2c03f31fbe54cd1dc7fc27c6628567fe86
      https://github.com/WebKit/WebKit/commit/d4bb9d2c03f31fbe54cd1dc7fc27c6628567fe86
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2024-07-05 (Fri, 05 Jul 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/svg/path/property/test_style_flush_on_dom_api_with_d_property-expected.txt
    M Source/WebCore/svg/SVGPathElement.cpp
    M Source/WebCore/svg/SVGPathElement.h

  Log Message:
  -----------
  [svg] WPT test `svg/path/property/test_style_flush_on_dom_api_with_d_property.html` has failures
https://bugs.webkit.org/show_bug.cgi?id=272621
rdar://126400894

Reviewed by Nikolas Zimmermann.

Since path data can be set via style now, we must make sure that layout is updated when the various
`SVGGeometryElement` DOM methods are called for path-related computations, including `getTotalLength()`,
`getPointAtLength()` and the `SVGPathElement` method `getPathSegAtLength()`. This was already done
for the other `SVGGeometryElement` DOM APIs `isPointInFill()` and `isPointInStroke()`.

We also ensure that the `SVGPathByteStream` we use to run the necessary computations in those methods
is the one held on the `SVGRenderStyle` by making `SVGPathElement::pathByteStream()` account for it.

* LayoutTests/imported/w3c/web-platform-tests/svg/path/property/test_style_flush_on_dom_api_with_d_property-expected.txt:
* Source/WebCore/svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::getTotalLength const):
(WebCore::SVGPathElement::getPointAtLength const):
(WebCore::SVGPathElement::getPathSegAtLength const):
(WebCore::SVGPathElement::pathByteStream const):
* Source/WebCore/svg/SVGPathElement.h:

Canonical link: https://commits.webkit.org/280675@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications