[webkit-changes] [WebKit/WebKit] 7b1e2f: When a layer size changes, recompute compositing f...

[Gerald Squelart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7b1e2f8cef2e6be5d52dd160ff14025bf8e592ae
      https://github.com/WebKit/WebKit/commit/7b1e2f8cef2e6be5d52dd160ff14025bf8e592ae
  Author: Gerald Squelart <g_squelart at apple.com>
  Date:   2024-07-04 (Thu, 04 Jul 2024)

  Changed paths:
    A LayoutTests/compositing/shared-backing/update-backing-sharing-on-geometry-change-expected.html
    A LayoutTests/compositing/shared-backing/update-backing-sharing-on-geometry-change.html
    A LayoutTests/compositing/shared-backing/update-backing-sharing-on-size-change-expected.html
    A LayoutTests/compositing/shared-backing/update-backing-sharing-on-size-change.html
    M Source/WebCore/rendering/RenderLayer.cpp

  Log Message:
  -----------
  When a layer size changes, recompute compositing from its stacking context down
https://bugs.webkit.org/show_bug.cgi?id=276216
rdar://130615925

Reviewed by Matt Woodrow.

In some cases, changing the size of an element could change how layers overlap,
so the compositing around it should be appropriately recomputed.

* LayoutTests/compositing/shared-backing/update-backing-sharing-on-geometry-change-expected.html: Added.
* LayoutTests/compositing/shared-backing/update-backing-sharing-on-geometry-change.html: Added.
Before this patch, the changing geometry of the container, which moves the red
square into/out of the yellow box, would not correctly update the green box.

* LayoutTests/compositing/shared-backing/update-backing-sharing-on-size-change-expected.html: Added.
* LayoutTests/compositing/shared-backing/update-backing-sharing-on-size-change.html: Added.
Before this patch, this reduced test case was triggering `ASSERT(provider)` in
RenderLayerCompositor::traverseUnchangedSubtree.

* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition):

Canonical link: https://commits.webkit.org/280673@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications