[webkit-changes] [WebKit/WebKit] fb1c6b: [svg] WPT test svg/path/property/mpath.svg is a fa...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fb1c6b94913ff523be3bc918d8179e3f912a7dcc
      https://github.com/WebKit/WebKit/commit/fb1c6b94913ff523be3bc918d8179e3f912a7dcc
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2024-07-03 (Wed, 03 Jul 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/rendering/svg/RenderSVGPath.cpp
    M Source/WebCore/rendering/svg/RenderSVGPath.h
    M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGPath.cpp
    M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGPath.h
    M Source/WebCore/svg/SVGPathElement.cpp
    M Source/WebCore/svg/SVGPathElement.h

  Log Message:
  -----------
  [svg] WPT test svg/path/property/mpath.svg is a failure
https://bugs.webkit.org/show_bug.cgi?id=272416
rdar://126398393

Reviewed by Nikolas Zimmermann.

While we have a mechanism in place to invalidate `<mpath>` elements when its referenced
element has a change in its `d` SVG attribute value, we don't do that for the case where
the `d` value is set via the CSS property.

We now implement `styleDidChange()` in both the legacy and the LBSE renderer for SVG paths
and call into the private `SVGPathElement::invalidateMPathDependencies()` through the new
public method `SVGPathElement::pathDidChange()`.

* LayoutTests/TestExpectations:
* Source/WebCore/rendering/svg/RenderSVGPath.cpp:
(WebCore::RenderSVGPath::styleDidChange):
* Source/WebCore/rendering/svg/RenderSVGPath.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGPath.cpp:
(WebCore::LegacyRenderSVGPath::styleDidChange):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGPath.h:
* Source/WebCore/svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::pathDidChange):
* Source/WebCore/svg/SVGPathElement.h:

Canonical link: https://commits.webkit.org/280657@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications