[webkit-changes] [WebKit/WebKit] 308acd: Demote WKWebView SPI that's are used only for test...

Wenson Hsieh noreply at github.com
Wed Jul 3 16:04:23 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 308acd124365dd2b711b82336deb50199cbd8cc0
      https://github.com/WebKit/WebKit/commit/308acd124365dd2b711b82336deb50199cbd8cc0
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-07-03 (Wed, 03 Jul 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
    M Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm
    M Source/WebKit/UIProcess/API/mac/WKWebViewPrivateForTestingMac.h
    M Source/WebKit/UIProcess/API/mac/WKWebViewTestingMac.mm

  Log Message:
  -----------
  Demote WKWebView SPI that's are used only for testing to internal methods
https://bugs.webkit.org/show_bug.cgi?id=276197

Reviewed by Aditya Keerthi and Abrar Rahman Protyasha.

Move these out of `WKWebViewPrivate.h` and into `WKWebViewPrivateForTestingMac.h`, so that they're
not part of the `WKWebView` SPI surface. As their names suggest, these methods are only used by API
tests, and are not intended to be used by any WebKit clients.

See: 279557 at main for more information.

* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
* Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm:
(-[WKWebView _createFlagsChangedEventMonitorForTesting]): Deleted.
(-[WKWebView _removeFlagsChangedEventMonitorForTesting]): Deleted.
* Source/WebKit/UIProcess/API/mac/WKWebViewPrivateForTestingMac.h:
* Source/WebKit/UIProcess/API/mac/WKWebViewTestingMac.mm:
(-[WKWebView _createFlagsChangedEventMonitorForTesting]):
(-[WKWebView _removeFlagsChangedEventMonitorForTesting]):

Canonical link: https://commits.webkit.org/280645@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list