[webkit-changes] [WebKit/WebKit] ebf65f: [WebXR] Many WPT tests crash in WebXROpaqueFramebu...

Dan Glastonbury noreply at github.com
Wed Jul 3 00:54:12 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ebf65f9d47ccc59bc21384b4384fc1055535f78c
      https://github.com/WebKit/WebKit/commit/ebf65f9d47ccc59bc21384b4384fc1055535f78c
  Author: Dan Glastonbury <djg at apple.com>
  Date:   2024-07-03 (Wed, 03 Jul 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_requestReferenceSpace_features.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_framebuffer_draw.https-expected.txt
    M LayoutTests/platform/visionos/TestExpectations
    M Source/WebCore/Modules/webxr/WebXROpaqueFramebufferCocoa.cpp

  Log Message:
  -----------
  [WebXR] Many WPT tests crash in WebXROpaqueFramebuffer dtor
https://bugs.webkit.org/show_bug.cgi?id=276159
rdar://131014002

Reviewed by Mike Wyrzykowski.

Many imported WebXR tests from WPT are asserting in
WebXROpaqueFramebuffer::~WebXROpaqueFramebuffer(). We have a GL object leak! The
display framebuffer, `m_displayFBO`, is not being released.

* LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_requestReferenceSpace_features.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_framebuffer_draw.https-expected.txt:
* LayoutTests/platform/visionos/TestExpectations:
* Source/WebCore/Modules/webxr/WebXROpaqueFramebufferCocoa.cpp:
(WebCore::WebXROpaqueFramebuffer::~WebXROpaqueFramebuffer):

Canonical link: https://commits.webkit.org/280615@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list