[webkit-changes] [WebKit/WebKit] 2ce73f: Ref count Element in `resolveAnchorValue()` for sa...

[David Choi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2ce73fd81990e9d078077569b417ac244bba34f0
      https://github.com/WebKit/WebKit/commit/2ce73fd81990e9d078077569b417ac244bba34f0
  Author: David Choi <davidchoi1027 at gmail.com>
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
    M Source/WebCore/style/AnchorPositionEvaluator.cpp
    M Source/WebCore/style/AnchorPositionEvaluator.h
    M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  -----------
  Ref count Element in `resolveAnchorValue()` for safety
https://bugs.webkit.org/show_bug.cgi?id=276142
rdar://130992562

Reviewed by Tim Nguyen and Ryan Reno.

Adds a RefPtr to an Element used for `resolveAnchorValue()` to ensure
the lifetime of the Element across the function call. Also guards
against a null pointer and uses safer getters.

* Source/WebCore/style/AnchorPositionEvaluator.cpp:
(WebCore::Style::AnchorPositionEvaluator::resolveAnchorValue):
* Source/WebCore/style/AnchorPositionEvaluator.h:
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertLength):

Canonical link: https://commits.webkit.org/280610@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications