[webkit-changes] [WebKit/WebKit] 603788: [browserperfdash-benchmark][run-benchmark] Add a m...

[Carlos Alberto Lopez Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 60378803adb761a768bdaa90c2a138174a9129db
      https://github.com/WebKit/WebKit/commit/60378803adb761a768bdaa90c2a138174a9129db
  Author: Carlos Alberto Lopez Perez <clopez at igalia.com>
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
    M Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py
    M Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py
    M Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py

  Log Message:
  -----------
  [browserperfdash-benchmark][run-benchmark] Add a method for getting the browser version and implement it for Chrome/Linux
https://bugs.webkit.org/show_bug.cgi?id=276125

Reviewed by Nikolas Zimmermann.

The script browserperfdash-benchmark needs to know the browser version
used for the tests, because that information is very relevant when
uploading the data to the dashboard. For tests with WPE that is easy as
we simply pass the revision number from the buildbot master.
But for other browsers we don't know the revision number when executing
the step. So this adds a new switch to browserperfdash-benchmark named
`--query-browser-version` that basically calls the browser driver method
`browser_version()` to obtain the version. It also implements this method
for the Chrome browser.
This doesn't change anything on the CLI of run-benchmark script.

* Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
(BrowserDriver):
(BrowserDriver.browser_version):
* Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
(LinuxChromeDriver.launch_driver):
(LinuxChromeDriver):
(LinuxChromeDriver.browser_version):
* Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
(parse_args):
(BrowserPerfDashRunner.run):

Canonical link: https://commits.webkit.org/280585@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications