[webkit-changes] [WebKit/WebKit] 330709: RenderElement::dirtyLinesFromChangedChild should o...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3307099eec741ff4eeef689730f471cc4ec760e2
      https://github.com/WebKit/WebKit/commit/3307099eec741ff4eeef689730f471cc4ec760e2
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
    M Source/WebCore/rendering/RenderBlock.cpp
    M Source/WebCore/rendering/RenderBlock.h
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/RenderElement.cpp
    M Source/WebCore/rendering/RenderInline.cpp
    M Source/WebCore/rendering/RenderLineBoxList.cpp
    M Source/WebCore/rendering/RenderObject.cpp

  Log Message:
  -----------
  RenderElement::dirtyLinesFromChangedChild should only be called on svg content
https://bugs.webkit.org/show_bug.cgi?id=276103

Reviewed by Antti Koivisto.

1. dirtyLinesFromChangedChild is a legacy line layout concept only applies to svg content now
2. svg inline content does not produce multiple lines -> remove redundant code in RenderLineBoxList::dirtyLinesFromChangedChild dealing with first/line lineboxes
3. svg content has either RenderBlockFlow or RenderInline base renderer -> remove RenderBlock::willBeDestroyed

* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::willBeDestroyed): Deleted.
* Source/WebCore/rendering/RenderBlock.h:
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::willBeDestroyed):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::willBeRemovedFromTree):
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::RenderInline::willBeDestroyed):
* Source/WebCore/rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::insertedIntoTree):

Canonical link: https://commits.webkit.org/280578@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications