[webkit-changes] [WebKit/WebKit] 8104e1: [WPE] WKWPE::View is refcounted

Carlos Garcia Campos noreply at github.com
Tue Jul 2 01:07:43 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8104e1d037fe1ef5d6824f8d893b5df6c2691452
      https://github.com/WebKit/WebKit/commit/8104e1d037fe1ef5d6824f8d893b5df6c2691452
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/C/wpe/WKView.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
    M Source/WebKit/UIProcess/API/wpe/WPEWebViewLegacy.h
    M Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.h
    M Tools/TestWebKitAPI/wpe/PlatformWebViewWPE.cpp
    M Tools/WebKitTestRunner/libwpe/PlatformWebViewClient.h

  Log Message:
  -----------
  [WPE] WKWPE::View is refcounted
https://bugs.webkit.org/show_bug.cgi?id=276059

Reviewed by Michael Catanzaro.

Create methods are returning a pointer, GLib API is using
std::unique_ptr and WKTR and API tests are leaking the view.

* Source/WebKit/UIProcess/API/C/wpe/WKView.cpp:
(WKViewCreate):
(WKViewCreateDeprecated):
* Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:
(webkitWebViewCreatePage):
* Source/WebKit/UIProcess/API/wpe/WPEWebViewLegacy.h:
* Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.h:
* Tools/TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
* Tools/WebKitTestRunner/libwpe/PlatformWebViewClient.h:
(WTR::PlatformWebViewClient::~PlatformWebViewClient):

Canonical link: https://commits.webkit.org/280568@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list