[webkit-changes] [WebKit/WebKit] fb03da: [macOS] Disable shadows for `NSWindow`s created fo...

Aditya Keerthi noreply at github.com
Mon Jul 1 19:06:52 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fb03da83a2a9e1f542ec8988711bd56f1a47e618
      https://github.com/WebKit/WebKit/commit/fb03da83a2a9e1f542ec8988711bd56f1a47e618
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2024-07-01 (Mon, 01 Jul 2024)

  Changed paths:
    M Tools/TestWebKitAPI/cocoa/TestWKWebView.mm
    M Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm

  Log Message:
  -----------
  [macOS] Disable shadows for `NSWindow`s created for testing
https://bugs.webkit.org/show_bug.cgi?id=276099
rdar://130925395

Reviewed by Richard Robinson and Abrar Rahman Protyasha.

Due to a regression in another component, shadows are causing issues running
tests on recent macOS builds.

`NSWindow` shadows are unnecessary for testing as frameless windows are used.
Simply remove them.

* Tools/TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[TestWKWebView _setUpTestWindow:]):
* Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):

Canonical link: https://commits.webkit.org/280562@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list