[webkit-changes] [WebKit/WebKit] 36f383: [WebVTT] Cues should use white-space:pre-line

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 36f38359156a0215fa0147c38f6c2e62e745bd89
      https://github.com/WebKit/WebKit/commit/36f38359156a0215fa0147c38f6c2e62e745bd89
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2024-07-01 (Mon, 01 Jul 2024)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/README.md
    A LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/basic-cue-rendering-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/basic-cue-rendering.html
    A LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/basic-cue-rendering.webvtt
    A LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/content/silence.m4a
    A LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/content/silence.mp3
    A LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/resources/reference.css
    A LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/resources/webvtt-rendering-test.js
    A LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/white-space-pre-line-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/white-space-pre-line.html
    A LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/white-space-pre-line.webvtt
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css
    M Source/WebCore/css/mediaControls.css

  Log Message:
  -----------
  [WebVTT] Cues should use white-space:pre-line
https://bugs.webkit.org/show_bug.cgi?id=275616
rdar://130084169

Reviewed by Eric Carlson.

The WebVTT spec requires:

> 7.4. Applying CSS properties to WebVTT Node Objects:
> The white-space property on the (root) list of WebVTT Node Objects must be set to pre-line. [CSS22]

Update our default styles for cues to use this value for `white-space:`. Add WPT reference tests to
verify the change. The test uses `mix-blend-mode` to combine the actual rendering and the expected
rendering into a green result.

* LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/README.md: Added.
* LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/basic-cue-rendering-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/basic-cue-rendering.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/basic-cue-rendering.webvtt: Added.
* LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/content/silence.m4a: Added.
* LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/content/silence.mp3: Added.
* LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/reference.css: Added.
* LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/white-space-pre-line-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/white-space-pre-line.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/white-space-pre-line.webvtt: Added.
* Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css:
(::-webkit-media-text-track-display):
* Source/WebCore/css/mediaControls.css:
(video::-webkit-media-text-track-display):

Canonical link: https://commits.webkit.org/280554@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications