[webkit-changes] [WebKit/WebKit] 8f84cb: [JSC] Inline hot part of op_enter in Baseline JIT

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8f84cbe944f64a1b34715c0257d9cfed5bdefc9f
      https://github.com/WebKit/WebKit/commit/8f84cbe944f64a1b34715c0257d9cfed5bdefc9f
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-07-01 (Mon, 01 Jul 2024)

  Changed paths:
    M Source/JavaScriptCore/bytecode/CodeBlock.cpp
    M Source/JavaScriptCore/bytecode/CodeBlock.h
    M Source/JavaScriptCore/jit/AssemblyHelpers.h
    M Source/JavaScriptCore/jit/BaselineJITRegisters.h
    M Source/JavaScriptCore/jit/JITOpcodes.cpp
    M Source/JavaScriptCore/jit/JITOperations.cpp
    M Source/JavaScriptCore/runtime/VM.h
    M Source/JavaScriptCore/runtime/VMTraps.h

  Log Message:
  -----------
  [JSC] Inline hot part of op_enter in Baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=276060
rdar://130879769

Reviewed by Yijia Huang.

Our new profiling identified that op_enter thunk call in Baseline JIT is too costly.
As the result of collecting data, we found that most of # of variables is very small.
So we should take fast-path-slow-path approach here. We inline fast path part in Baseline JIT code,
and jumping to the generic slow thunk when we found it hits the slow case.

* Source/JavaScriptCore/bytecode/CodeBlock.cpp:
(JSC::CodeBlock::capabilityLevel):
* Source/JavaScriptCore/bytecode/CodeBlock.h:
(JSC::CodeBlock::offsetOfVM):
* Source/JavaScriptCore/jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::branchIfBarriered):
* Source/JavaScriptCore/jit/BaselineJITRegisters.h:
* Source/JavaScriptCore/jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_enter):
(JSC::JIT::op_enter_handlerGenerator):
(JSC::JIT::emitSlow_op_enter):
* Source/JavaScriptCore/jit/JITOperations.cpp:
(JSC::JSC_DEFINE_JIT_OPERATION):
* Source/JavaScriptCore/runtime/VM.h:
(JSC::VM::offsetOfTrapsBits):
* Source/JavaScriptCore/runtime/VMTraps.h:
(JSC::VMTraps::offsetOfTrapsBits):

Canonical link: https://commits.webkit.org/280547@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications