[webkit-changes] [WebKit/WebKit] de1593: CrashTracer: com.apple.WebKit.WebContent at WebCor...

Tim Nguyen noreply at github.com
Wed Jan 31 21:57:25 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: de15933efb3df90ef3af89e73f48847471f22700
      https://github.com/WebKit/WebKit/commit/de15933efb3df90ef3af89e73f48847471f22700
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-01-31 (Wed, 31 Jan 2024)

  Changed paths:
    A LayoutTests/fullscreen/fullscreen-add-disconnected-to-top-layer-expected.txt
    A LayoutTests/fullscreen/fullscreen-add-disconnected-to-top-layer.html
    M Source/WebCore/dom/Document.cpp

  Log Message:
  -----------
  CrashTracer: com.apple.WebKit.WebContent at WebCore: WebCore::Document::addTopLayerElement
https://bugs.webkit.org/show_bug.cgi?id=268434
rdar://117975912

Reviewed by Chris Dumez.

The release assertion here is bogus, the top layer is a DOM construct that is used for various DOM algorithms, not just a rendering one.

Things in the top layer are not required to be rendered.

* LayoutTests/fullscreen/fullscreen-add-disconnected-to-top-layer-expected.txt: Added.
* LayoutTests/fullscreen/fullscreen-add-disconnected-to-top-layer.html: Added.
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::addTopLayerElement):

Canonical link: https://commits.webkit.org/273885@main




More information about the webkit-changes mailing list