[webkit-changes] [WebKit/WebKit] 05e445: [ SonomaB wk2 Debug arm64 ] http/tests/inspector/d...

Jean-Yves Avenard noreply at github.com
Wed Jan 31 16:13:57 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 05e445aaf98a0afb586f0e5bfa9df422d082034a
      https://github.com/WebKit/WebKit/commit/05e445aaf98a0afb586f0e5bfa9df422d082034a
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-01-31 (Wed, 31 Jan 2024)

  Changed paths:
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WebCore/html/HTMLMediaElement.h
    M Source/WebCore/html/HTMLVideoElement.cpp

  Log Message:
  -----------
  [ SonomaB wk2 Debug arm64 ] http/tests/inspector/dom/didFireEvent.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=268423
rdar://121970654

Reviewed by Youenn Fablet.

If the RenderLayerCompositor had queried the element's MediaPlayer::supportsAcceleratedRendering prior the player having been created it would have been set to false.
Follow-up render after the MediaPlayerPrivate had been created would trigger an assertion.

Prior 273406 at main, the MediaPlayerPrivateRemote would call mediaPlayerRenderingModeChanged in its constructor hiding the issue.
Generalise the fix to all MediaPlayerPrivate.

* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebCore/html/HTMLMediaElement.h:
* Source/WebCore/html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::mediaPlayerEngineUpdated):

Canonical link: https://commits.webkit.org/273867@main




More information about the webkit-changes mailing list