[webkit-changes] [WebKit/WebKit] 9f7e22: REGRESSION: A floating element can cause the latte...

Alan Baradlay noreply at github.com
Wed Jan 31 10:03:09 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9f7e229a06634c2cca99b80c688116289e0fb55f
      https://github.com/WebKit/WebKit/commit/9f7e229a06634c2cca99b80c688116289e0fb55f
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-01-31 (Wed, 31 Jan 2024)

  Changed paths:
    A LayoutTests/fast/inline/intrusive-float-with-no-available-space-and-partial-content-expected.html
    A LayoutTests/fast/inline/intrusive-float-with-no-available-space-and-partial-content.html
    M Source/WebCore/layout/floats/FloatingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineContentBalancer.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.cpp

  Log Message:
  -----------
  REGRESSION: A floating element can cause the latter half of a hyphenated word to disappear
https://bugs.webkit.org/show_bug.cgi?id=268346
<rdar://problem/121889487>

Reviewed by Antti Koivisto.

It's okay to not being able to advance on the inline content even when it is partial (either through hyphenation or arbitrary breaking position) when
there is an intrusive float on the line.

* LayoutTests/fast/inline/intrusive-float-with-no-available-space-and-partial-content-expected.html: Added.
* LayoutTests/fast/inline/intrusive-float-with-no-available-space-and-partial-content.html: Added.
* Source/WebCore/layout/floats/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::constraints const):
* Source/WebCore/layout/formattingContexts/inline/InlineContentBalancer.cpp:
(WebCore::Layout::InlineContentBalancer::initialize):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::lineLayout):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp:
(WebCore::Layout::InlineFormattingUtils::leadingInlineItemPositionForNextLine):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::placeInlineAndFloatContent):
* Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.cpp:
(WebCore::Layout::IntrinsicWidthHandler::computedIntrinsicWidthForConstraint):

Canonical link: https://commits.webkit.org/273836@main




More information about the webkit-changes mailing list