[webkit-changes] [WebKit/WebKit] 33669e: Remove isCharacterData() in favor of isCharacterDa...

Anne van Kesteren noreply at github.com
Wed Jan 31 06:12:37 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 33669e346c09920b70b4edda5d1a5014410c4dc6
      https://github.com/WebKit/WebKit/commit/33669e346c09920b70b4edda5d1a5014410c4dc6
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2024-01-31 (Wed, 31 Jan 2024)

  Changed paths:
    M Source/WebCore/dom/CharacterData.h
    M Source/WebCore/dom/Node.h
    M Source/WebCore/dom/Position.h

  Log Message:
  -----------
  Remove isCharacterData() in favor of isCharacterDataNode()
https://bugs.webkit.org/show_bug.cgi?id=268444

Reviewed by Alexey Shvayka.

The latter is more widespread and seems like a reasonable enough name
given the other type getter names.

* Source/WebCore/dom/CharacterData.h:
* Source/WebCore/dom/Node.h:
(WebCore::Node::isCharacterDataNode const):
(WebCore::Node::isAttributeNode const):
(WebCore::Node::isCharacterData const): Deleted.
* Source/WebCore/dom/Position.h:
(WebCore::firstPositionInNode):
(WebCore::lastPositionInNode):

Canonical link: https://commits.webkit.org/273826@main




More information about the webkit-changes mailing list