[webkit-changes] [WebKit/WebKit] 412734: Introduce PseudoElementIdentifier

Tim Nguyen noreply at github.com
Tue Jan 30 20:59:29 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 412734d26e78c3750bbd702e323d11d22c36aaf0
      https://github.com/WebKit/WebKit/commit/412734d26e78c3750bbd702e323d11d22c36aaf0
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/rendering/RenderElement.cpp
    M Source/WebCore/style/ElementRuleCollector.cpp
    A Source/WebCore/style/PseudoElementIdentifier.h
    M Source/WebCore/style/PseudoElementRequest.h
    M Source/WebCore/style/StyleResolver.cpp

  Log Message:
  -----------
  Introduce PseudoElementIdentifier
https://bugs.webkit.org/show_bug.cgi?id=268412
rdar://121959648

Reviewed by Darin Adler.

We want to separate this from PseudoElementRequest so we can re-use it in other places.

* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::getUncachedPseudoStyle const):
* Source/WebCore/style/ElementRuleCollector.cpp:
(WebCore::Style::ElementRuleCollector::collectMatchingRules):
(WebCore::Style::ElementRuleCollector::ruleMatches):
(WebCore::Style::ElementRuleCollector::collectMatchingRulesForList):
(WebCore::Style::ElementRuleCollector::addAuthorKeyframeRules):
* Source/WebCore/style/PseudoElementIdentifier.h: Copied from Source/WebCore/style/PseudoElementRequest.h.
(WebCore::Style::PseudoElementIdentifier::PseudoElementIdentifier):
* Source/WebCore/style/PseudoElementRequest.h:
(WebCore::Style::PseudoElementRequest::PseudoElementRequest):
(WebCore::Style::PseudoElementRequest::identifier const):
(WebCore::Style::PseudoElementRequest::pseudoId const):
(WebCore::Style::PseudoElementRequest::pseudoElementNameArgument const):
(WebCore::Style::PseudoElementRequest::scrollbarState const):
* Source/WebCore/style/StyleResolver.cpp:
(WebCore::Style::Resolver::styleForPseudoElement):

Canonical link: https://commits.webkit.org/273809@main




More information about the webkit-changes mailing list