[webkit-changes] [WebKit/WebKit] fa7db0: [JSC] Do not destroy VM after clearing AtomStringT...

Yusuke Suzuki noreply at github.com
Tue Jan 30 18:04:00 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fa7db09c3bb2ba6f4263dce4b0d55aad85e02260
      https://github.com/WebKit/WebKit/commit/fa7db09c3bb2ba6f4263dce4b0d55aad85e02260
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M Source/JavaScriptCore/runtime/JSLock.cpp

  Log Message:
  -----------
  [JSC] Do not destroy VM after clearing AtomStringTable for current thread
https://bugs.webkit.org/show_bug.cgi?id=268415
rdar://86151259

Reviewed by Michael Saboff.

This patch changes the ordering of VM destruction and thread's AtomStringTable clearing.
This happens when JSVirtualMachine gets destroyed during execution of microtasks. While this
should not happen (because it is destroying VM while running code associated to this VM), we
can alleviate this case by destroying VM under the right AtomStringTable.

* Source/JavaScriptCore/runtime/JSLock.cpp:
(JSC::JSLock::willReleaseLock):

Canonical link: https://commits.webkit.org/273803@main




More information about the webkit-changes mailing list