[webkit-changes] [WebKit/WebKit] 5d4d9c: TestShard should be able to pickle reference_files

Sam Sneddon noreply at github.com
Tue Jan 30 14:18:50 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5d4d9c7ef39a8e0c948023df3eefb440070c3999
      https://github.com/WebKit/WebKit/commit/5d4d9c7ef39a8e0c948023df3eefb440070c3999
  Author: Sam Sneddon <gsnedders at apple.com>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py
    M Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py

  Log Message:
  -----------
  TestShard should be able to pickle reference_files
https://bugs.webkit.org/show_bug.cgi?id=268379

Reviewed by Jonathan Bedard.

Previously, this got the type of reference_files wrong. This happened to
work because we never actually set it anywhere. However, on a local
branch where it is set this unsurprisingly fails.

* Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(TestShard.pack):
* Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
(LayoutTestRunnerTests.test_interrupt_if_at_failure_limits): Drive-by, remove dead variable.
(ShardTests):
(ShardTests.test_pickle):

Canonical link: https://commits.webkit.org/273789@main




More information about the webkit-changes mailing list