[webkit-changes] [WebKit/WebKit] 878342: VideoTrackGenerator writer should get closed when ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8783423626ac3523165d5d1ec2794eabafba010c
      https://github.com/WebKit/WebKit/commit/8783423626ac3523165d5d1ec2794eabafba010c
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/VideoTrackGenerator.worker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/VideoTrackGenerator.worker.js
    A LayoutTests/platform/gtk/imported/w3c/web-platform-tests/mediacapture-insertable-streams/VideoTrackGenerator.worker-expected.txt
    M Source/WebCore/Modules/mediastream/VideoTrackGenerator.cpp
    M Source/WebCore/Modules/mediastream/VideoTrackGenerator.h
    M Source/WebCore/Modules/streams/WritableStream.cpp
    M Source/WebCore/Modules/streams/WritableStream.h
    M Source/WebCore/Modules/streams/WritableStreamInternals.js
    M Source/WebCore/bindings/js/InternalWritableStream.cpp
    M Source/WebCore/bindings/js/InternalWritableStream.h

  Log Message:
  -----------
  VideoTrackGenerator writer should get closed when its generator track (and all its clones) are stopped
rdar://121835553
https://bugs.webkit.org/show_bug.cgi?id=268279

Reviewed by Jean-Yves Avenard.

Implement VideoTrackGenerator::Source::endProducingData to make sure to close VideoTrackGenerator writable when the source is stopped.
Introduce WritableStream::close to implement this.
The VideoTrackGenerator::Source keeps a WeakPtr of the WritableStream to call WritableStream::close.

We introduce closeWritableStreamIfPossible built-in to only close the writable stream if it is not already closed.

Add corresponding WPT tests.
We also fix a test in VideoTrackGenerator.worker.js which is about trying to write to a video track generator non VideoFrames.
We use AudioData, which cannot be created yet in Cocoa ports, hence the failure.

* LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/VideoTrackGenerator.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/VideoTrackGenerator.worker.js:
(make_audio_data):
(promise_test.async t):
* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/mediacapture-insertable-streams/VideoTrackGenerator.worker-expected.txt: Added.
* Source/WebCore/Modules/mediastream/VideoTrackGenerator.cpp:
(WebCore::VideoTrackGenerator::create):
(WebCore::VideoTrackGenerator::Source::Source):
(WebCore::m_contextIdentifier):
(WebCore::VideoTrackGenerator::Source::endProducingData):
(WebCore::VideoTrackGenerator::Source::setWritable):
(WebCore::VideoTrackGenerator::Source::writeVideoFrame):
* Source/WebCore/Modules/mediastream/VideoTrackGenerator.h:
* Source/WebCore/Modules/streams/WritableStream.cpp:
(WebCore::WritableStream::closeIfPossible):
(WebCore::JSWritableStream::abort):
(WebCore::JSWritableStream::close):
* Source/WebCore/Modules/streams/WritableStream.h:
* Source/WebCore/Modules/streams/WritableStreamInternals.js:
(writableStreamCloseIfPossible):
* Source/WebCore/bindings/js/InternalWritableStream.cpp:
(WebCore::InternalWritableStream::abortForBindings):
(WebCore::InternalWritableStream::closeForBindings):
(WebCore::InternalWritableStream::closeIfPossible):
(WebCore::InternalWritableStream::abort): Deleted.
(WebCore::InternalWritableStream::close): Deleted.
* Source/WebCore/bindings/js/InternalWritableStream.h:

Canonical link: https://commits.webkit.org/273778@main