[webkit-changes] [WebKit/WebKit] 1cac16: Add logging to help investigate issues where keybo...

Wenson Hsieh noreply at github.com
Tue Jan 30 12:15:53 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1cac16a58aac599e2465832721a1dd10a483b0e0
      https://github.com/WebKit/WebKit/commit/1cac16a58aac599e2465832721a1dd10a483b0e0
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  -----------
  Add logging to help investigate issues where keyboard input fails to insert text on iOS 17.4
https://bugs.webkit.org/show_bug.cgi?id=268392
rdar://121665022

Reviewed by Aditya Keerthi.

Try to zero in on cases where typing on the software keyboard fails to insert text in `WKWebView`,
by testing one of my current hypotheses that this happens when the `_asyncInputDelegate` is `nil`
when receiving calls to `-handleKeyEntry:withCompletionHandler:` and related methods.

Note that I'm throttling these log messages to a maximum of just one every 10 seconds, to avoid
spamming log messages when typing, if the device is in state.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _deferKeyEventToInputMethodEditing:]):
(-[WKContentView _interpretKeyEvent:isCharEvent:]):
(-[WKContentView _logMissingSystemInputDelegateIfNeeded:]):

Canonical link: https://commits.webkit.org/273776@main




More information about the webkit-changes mailing list