[webkit-changes] [WebKit/WebKit] c0ce52: The ProcessAssertion object should hold a Assertio...

Per Arne Vollan noreply at github.com
Tue Jan 30 10:55:16 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c0ce523ac7bf189cb5b130204736ac936c4c9312
      https://github.com/WebKit/WebKit/commit/c0ce523ac7bf189cb5b130204736ac936c4c9312
  Author: Per Arne Vollan <pvollan at apple.com>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M Source/WebKit/Platform/cocoa/AssertionCapability.h
    M Source/WebKit/Platform/cocoa/AssertionCapability.mm
    M Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm
    M Source/WebKit/UIProcess/ProcessAssertion.h

  Log Message:
  -----------
  The ProcessAssertion object should hold a AssertionCapability object
https://bugs.webkit.org/show_bug.cgi?id=268343
rdar://121614924

Reviewed by Chris Dumez.

The ProcessAssertion object should hold a AssertionCapability object, and not a platform _SECapability object.
Otherwise, the invalidation blocks will be deleted in the ProcessAssertion constructor, since we only created
a temporary object there.

* Source/WebKit/Platform/cocoa/AssertionCapability.h:
* Source/WebKit/Platform/cocoa/AssertionCapability.mm:
(WebKit::AssertionCapability::platformCapability const):
* Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm:
(WebKit::ProcessAssertion::ProcessAssertion):
(WebKit::ProcessAssertion::acquireSync):
* Source/WebKit/UIProcess/ProcessAssertion.h:

Canonical link: https://commits.webkit.org/273769@main




More information about the webkit-changes mailing list