[webkit-changes] [WebKit/WebKit] da9bdb: [WGSL] Crash when type checking vector field access

Tadeu Zagallo noreply at github.com
Tue Jan 30 10:18:25 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: da9bdbe963c5b8b3f06caaa479f33d0fe58e4c23
      https://github.com/WebKit/WebKit/commit/da9bdbe963c5b8b3f06caaa479f33d0fe58e4c23
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M Source/WebGPU/WGSL/TypeCheck.cpp
    M Source/WebGPU/WGSL/tests/invalid/access-expression.wgsl

  Log Message:
  -----------
  [WGSL] Crash when type checking vector field access
https://bugs.webkit.org/show_bug.cgi?id=268385
rdar://121528527

Reviewed by Mike Wyrzykowski.

vectorFieldAccess can return nullptr if the access is invalid, so we need to check
the result before dereferencing it.

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/tests/invalid/access-expression.wgsl:

Canonical link: https://commits.webkit.org/273766@main




More information about the webkit-changes mailing list