[webkit-changes] [WebKit/WebKit] ce842b: [WGSL] Should not attempt to convert constants if ...

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ce842bee80c8d1a1c149c2f85762f407ef7b1c7f
      https://github.com/WebKit/WebKit/commit/ce842bee80c8d1a1c149c2f85762f407ef7b1c7f
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
    M Source/WebGPU/WGSL/TypeCheck.cpp

  Log Message:
  -----------
  [WGSL] Should not attempt to convert constants if type checking failed
https://bugs.webkit.org/show_bug.cgi?id=268304
rdar://121527220

Reviewed by Mike Wyrzykowski.

Usually we check for bottom types before calling into convertValue, but it seems
less error prone to handle it in convertValue itself. While I was in there I also
stopped calling resolveType twice on the function parameters to avoid duplicate
error messages.

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
(WGSL::TypeChecker::convertValue):

Canonical link: https://commits.webkit.org/273751@main