[webkit-changes] [WebKit/WebKit] 261403: [IFC][Subpixel] InlineLevelBox::preferredLineHeigh...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 261403ac5d01cc0e729338876139d203f9f1d75c
      https://github.com/WebKit/WebKit/commit/261403ac5d01cc0e729338876139d203f9f1d75c
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-01-29 (Mon, 29 Jan 2024)

  Changed paths:
    R LayoutTests/fast/forms/textAreaLineHeight-simple-lines-expected.html
    R LayoutTests/fast/forms/textAreaLineHeight-simple-lines.html
    M LayoutTests/platform/ios-wk2/css2.1/t1508-c527-font-09-b-expected.txt
    M LayoutTests/platform/ios/compositing/overflow/nested-scrolling-expected.txt
    M LayoutTests/platform/ios/css1/font_properties/font-expected.txt
    M LayoutTests/platform/ios/css1/text_properties/line_height-expected.txt
    M LayoutTests/platform/ios/fast/block/positioning/047-expected.txt
    M LayoutTests/platform/ios/fast/borders/border-radius-split-inline-expected.txt
    M LayoutTests/platform/ios/fast/css/negative-leading-expected.txt
    M LayoutTests/platform/ios/fast/forms/control-restrict-line-height-expected.txt
    M LayoutTests/platform/ios/fast/overflow/infiniteRecursionGuard-expected.txt
    M LayoutTests/platform/ios/svg/custom/svg-fonts-in-html-expected.txt
    M LayoutTests/platform/mac-monterey/svg/custom/svg-fonts-in-html-expected.txt
    M LayoutTests/platform/mac-monterey/tables/mozilla/bugs/bug2479-2-expected.txt
    M LayoutTests/platform/mac/css1/font_properties/font-expected.txt
    M LayoutTests/platform/mac/css1/text_properties/line_height-expected.txt
    M LayoutTests/platform/mac/css2.1/t090501-c414-flt-ln-00-d-expected.txt
    M LayoutTests/platform/mac/css2.1/t090501-c414-flt-ln-01-d-g-expected.txt
    M LayoutTests/platform/mac/css2.1/t090501-c414-flt-ln-02-d-expected.txt
    M LayoutTests/platform/mac/css2.1/t090501-c414-flt-ln-03-d-expected.txt
    M LayoutTests/platform/mac/fast/block/positioning/047-expected.txt
    M LayoutTests/platform/mac/fast/css/negative-leading-expected.txt
    M LayoutTests/platform/mac/http/tests/misc/acid3-expected.txt
    M LayoutTests/platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt
    M LayoutTests/platform/mac/svg/custom/svg-fonts-in-html-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug2886-2-expected.txt
    M Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h

  Log Message:
  -----------
  [IFC][Subpixel] InlineLevelBox::preferredLineHeight should return non-floored value
https://bugs.webkit.org/show_bug.cgi?id=268270

Reviewed by Antti Koivisto.

This integral-floor was added to match legacy line layout.

* Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:
(WebCore::Layout::InlineLevelBox::preferredLineHeight const):

(/fast/forms/textAreaLineHeight-simple-lines.html ref test was added to check if these 2 codepaths were producing the same line height)

Canonical link: https://commits.webkit.org/273714@main