[webkit-changes] [WebKit/WebKit] dc7a51: Crash under VideoPresentationManagerProxy::createL...

Chris Dumez noreply at github.com
Mon Jan 29 17:25:09 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dc7a514214ae5eaf25ec39f5d49f674c99e15544
      https://github.com/WebKit/WebKit/commit/dc7a514214ae5eaf25ec39f5d49f674c99e15544
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-01-29 (Mon, 29 Jan 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm

  Log Message:
  -----------
  Crash under VideoPresentationManagerProxy::createLayerHostViewWithID()
https://bugs.webkit.org/show_bug.cgi?id=268320
rdar://121747495

Reviewed by Per Arne Vollan.

Null check the GPUProcess before dereferencing it. Even though we had a
GPUProcess to generate the id in the first place, the ID comes from IPC
from the WebProcess and things are just racing. We shouldn't assume the
GPUProcess is still running by the time we get the IPC.

* Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm:
(WebKit::VideoPresentationManagerProxy::createLayerHostViewWithID):

Canonical link: https://commits.webkit.org/273707@main




More information about the webkit-changes mailing list