[webkit-changes] [WebKit/WebKit] 2a038d: WebKit::displayStorageAccessAlert leaks an NSTextView

Commit Queue noreply at github.com
Mon Jan 29 12:34:26 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2a038d86cb46e23f1c1ba420f9209e9c29ed2d3c
      https://github.com/WebKit/WebKit/commit/2a038d86cb46e23f1c1ba420f9209e9c29ed2d3c
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2024-01-29 (Mon, 29 Jan 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/WKStorageAccessAlert.mm

  Log Message:
  -----------
  WebKit::displayStorageAccessAlert leaks an NSTextView
https://bugs.webkit.org/show_bug.cgi?id=268309
<rdar://121864691>

Reviewed by Aditya Keerthi.

* Source/WebKit/UIProcess/Cocoa/WKStorageAccessAlert.mm:
(WebKit::displayStorageAccessAlert):
- Use adoptNS() to fix the leak.
- Change `mutableString` to `auto *` type to hint that it's a pointer.

Canonical link: https://commits.webkit.org/273678@main




More information about the webkit-changes mailing list