[webkit-changes] [WebKit/WebKit] 385ddc: [UnifiedPDF] Hook up incremental PDF loading

Simon Fraser noreply at github.com
Mon Jan 29 10:48:01 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 385ddccf0be7190f406577d4eb8c7bd9a2144255
      https://github.com/WebKit/WebKit/commit/385ddccf0be7190f406577d4eb8c7bd9a2144255
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-01-29 (Mon, 29 Jan 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/http/tests/pdf/linearized-pdf-in-iframe-expected.html
    A LayoutTests/http/tests/pdf/linearized-pdf-in-iframe.html
    A LayoutTests/http/tests/pdf/resources/linearized.pdf
    A LayoutTests/http/tests/pdf/resources/non-linearized.pdf
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm
    M Source/WebKit/WebProcess/Plugins/PluginView.cpp

  Log Message:
  -----------
  [UnifiedPDF] Hook up incremental PDF loading
https://bugs.webkit.org/show_bug.cgi?id=268209
rdar://118550660

Reviewed by Tim Horton.

Hook up a `PDFIncrementalLoader` in PDFPluginBase so that the UnifiedPDF plugin can
use one.

This is moved into a new function, called from the `PluginView` constructor, so
that it's called after the object is fully constructed.

Added an http test that streams out a linearized PDF.

* LayoutTests/TestExpectations:
* LayoutTests/http/tests/pdf/linearized-pdf-in-iframe-expected.html: Added.
* LayoutTests/http/tests/pdf/linearized-pdf-in-iframe.html: Added.
* LayoutTests/http/tests/pdf/resources/linearized.pdf: Added.
* LayoutTests/http/tests/pdf/resources/non-linearized.pdf: Added.
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::PDFPlugin):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::startLoading):
* Source/WebKit/WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::PluginView):

Canonical link: https://commits.webkit.org/273670@main




More information about the webkit-changes mailing list