[webkit-changes] [WebKit/WebKit] b59448: [WGSL] Array constructors must have constant size

Tadeu Zagallo noreply at github.com
Mon Jan 29 07:40:31 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b59448c2d72c9e924060a7aa8e0d089b4eb536ba
      https://github.com/WebKit/WebKit/commit/b59448c2d72c9e924060a7aa8e0d089b4eb536ba
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-01-29 (Mon, 29 Jan 2024)

  Changed paths:
    M Source/WebGPU/WGSL/TypeCheck.cpp
    M Source/WebGPU/WGSL/tests/invalid/array.wgsl

  Log Message:
  -----------
  [WGSL] Array constructors must have constant size
https://bugs.webkit.org/show_bug.cgi?id=268172
rdar://121527822

Reviewed by Mike Wyrzykowski.

The type checker already assume there would be a size, but it never actually checked,
so we got an assertion error.

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/tests/invalid/array.wgsl:

Canonical link: https://commits.webkit.org/273653@main




More information about the webkit-changes mailing list