[webkit-changes] [WebKit/WebKit] 58e3ab: Attachment: Use opaque background color to ensure ...

[Gerald Squelart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 58e3ab08228ff163f000cba1a2786e9c9f7c9bbc
      https://github.com/WebKit/WebKit/commit/58e3ab08228ff163f000cba1a2786e9c9f7c9bbc
  Author: Gerald Squelart <g_squelart at apple.com>
  Date:   2024-01-28 (Sun, 28 Jan 2024)

  Changed paths:
    M LayoutTests/fast/attachment/mac/wide-attachment-image-controls-basic-expected.txt
    M LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt
    R LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt
    M LayoutTests/platform/mac/fast/attachment/cocoa/wide-attachment-rendering-expected.txt
    M Source/WebCore/html/HTMLAttachmentElement.cpp
    M Source/WebCore/html/shadow/attachmentElementShadow.css

  Log Message:
  -----------
  Attachment: Use opaque background color to ensure readability
https://bugs.webkit.org/show_bug.cgi?id=267253
rdar://117749005

Reviewed by Tim Nguyen.

The system colors used for the attachment background are very transparent,
which could render the attachment contents less readable if whatever is
under the attachment is of a similar color as the attachment text.
This issue can be prevented by making the background fully opaque.
The original transparent color has been moved to a new child div.

* LayoutTests/fast/attachment/mac/wide-attachment-image-controls-basic-expected.txt:
* LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt:
* LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt: Removed.
* LayoutTests/platform/mac/fast/attachment/cocoa/wide-attachment-rendering-expected.txt:
* Source/WebCore/html/HTMLAttachmentElement.cpp:
(WebCore::attachmentBackgroundIdentifier):
(WebCore::HTMLAttachmentElement::ensureWideLayoutShadowTree):
* Source/WebCore/html/shadow/attachmentElementShadow.css:
(div#attachment-container):
(div#attachment-background):

Canonical link: https://commits.webkit.org/273642@main