[webkit-changes] [WebKit/WebKit] 705788: Make `:-webkit-full-screen-document` an internal p...

Tim Nguyen noreply at github.com
Sun Jan 28 21:11:06 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 705788983f0a6269351404a12ba9d3d603f62a42
      https://github.com/WebKit/WebKit/commit/705788983f0a6269351404a12ba9d3d603f62a42
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-01-28 (Sun, 28 Jan 2024)

  Changed paths:
    M LayoutTests/fullscreen/full-screen-css.html
    M LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/invalid-pseudos-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/invalid-pseudos.html
    M ManualTests/fullscreen/full-screen-flash.html
    M Source/WebCore/Modules/modern-media-controls/controls/media-controls.css
    M Source/WebCore/css/CSSPseudoSelectors.json
    M Source/WebCore/css/SelectorChecker.cpp
    M Source/WebCore/css/SelectorCheckerTestFunctions.h
    M Source/WebCore/css/fullscreen.css
    M Source/WebCore/css/process-css-pseudo-selectors.py
    M Source/WebCore/cssjit/SelectorCompiler.cpp
    M Source/WebCore/dom/FullscreenManager.cpp
    M Source/WebCore/html/shadow/imageOverlay.css

  Log Message:
  -----------
  Make `:-webkit-full-screen-document` an internal pseudo-class
https://bugs.webkit.org/show_bug.cgi?id=268234
rdar://121816310

Reviewed by Darin Adler.

The main use of this is the UA stylesheet. Websites can use `:root:is(:fullscreen, :has(:fullscreen))` to achieve the same effect.

Let's attempt to unexpose this pseudo-class.

Also change 'full-screen' to 'fullscreen' for consistency with spec language.

* LayoutTests/fullscreen/full-screen-css.html:
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/invalid-pseudos-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/invalid-pseudos.html:
* ManualTests/fullscreen/full-screen-flash.html:
* Source/WebCore/Modules/modern-media-controls/controls/media-controls.css:
(:host(:-internal-animating-fullscreen-transition) .media-controls):
(:host(:-internal-animating-full-screen-transition) .media-controls): Deleted.
* Source/WebCore/css/CSSPseudoSelectors.json:
* Source/WebCore/css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne const):
* Source/WebCore/css/SelectorCheckerTestFunctions.h:
(WebCore::matchesAnimatingFullscreenTransitionPseudoClass):
(WebCore::matchesFullscreenDocumentPseudoClass):
(WebCore::matchesFullScreenAnimatingFullScreenTransitionPseudoClass): Deleted.
(WebCore::matchesFullScreenDocumentPseudoClass): Deleted.
* Source/WebCore/css/fullscreen.css:
(*|*:root:-internal-fullscreen-document:not(:fullscreen)):
(*|*:root:-webkit-full-screen-document:not(:fullscreen)): Deleted.
* Source/WebCore/css/process-css-pseudo-selectors.py:
* Source/WebCore/cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::JSC_DEFINE_JIT_OPERATION):
(WebCore::SelectorCompiler::addPseudoClassType):
* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::setAnimatingFullscreen):
* Source/WebCore/html/shadow/imageOverlay.css:
(:host(:not(img)) div#image-overlay:-internal-fullscreen-document):
(:host(:not(img)) div#image-overlay:-webkit-full-screen-document): Deleted.

Canonical link: https://commits.webkit.org/273639@main




More information about the webkit-changes mailing list