[webkit-changes] [WebKit/WebKit] 7fedc9: [Site Isolation] `findString:` should respect Find...
Charlie Wolfe
noreply at github.com
Sun Jan 28 17:59:36 PST 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7fedc933c2e5d3335c0e053ee6278eefe4baf403
https://github.com/WebKit/WebKit/commit/7fedc933c2e5d3335c0e053ee6278eefe4baf403
Author: Charlie Wolfe <charliew at apple.com>
Date: 2024-01-28 (Sun, 28 Jan 2024)
Changed paths:
M Source/WebKit/UIProcess/FindStringCallbackAggregator.cpp
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm
Log Message:
-----------
[Site Isolation] `findString:` should respect FindOptions::WrapAround
https://bugs.webkit.org/show_bug.cgi?id=268174
rdar://121674996
Reviewed by Aditya Keerthi and Alex Christensen.
When FindOptions::WrapAround is not passed to `findString:` selection we should not wrap to the main
frame and selection should be cleared after cycling through all matches.
* Source/WebKit/UIProcess/FindStringCallbackAggregator.cpp:
(WebKit::FindStringCallbackAggregator::~FindStringCallbackAggregator):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::clearSelection):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/273635@main
More information about the webkit-changes
mailing list