[webkit-changes] [WebKit/WebKit] 6c8700: [IFC][Intrinsic width] IntrinsicWidthHandler::Line...

Alan Baradlay noreply at github.com
Sun Jan 28 10:51:16 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6c870093215c9e64c1da8b72cf81dff0f6710c12
      https://github.com/WebKit/WebKit/commit/6c870093215c9e64c1da8b72cf81dff0f6710c12
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-01-28 (Sun, 28 Jan 2024)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineContentCache.h
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.cpp
    M Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.h

  Log Message:
  -----------
  [IFC][Intrinsic width] IntrinsicWidthHandler::LineBreakingResult's constraint member is redundant
https://bugs.webkit.org/show_bug.cgi?id=268212

Reviewed by Antti Koivisto.

LineBreakingResult.constraint always matches the maximum content width, so let's just use that instead.

* Source/WebCore/layout/formattingContexts/inline/InlineContentCache.h:
(WebCore::Layout::InlineContentCache::setMaximumIntrinsicWidthLineContent):
(WebCore::Layout::InlineContentCache::clearMaximumIntrinsicWidthLineContent):
(WebCore::Layout::InlineContentCache::maximumIntrinsicWidthLineContent):
(WebCore::Layout::InlineContentCache::resetMinimumMaximumContentSizes):
(WebCore::Layout::InlineContentCache::setMaximumIntrinsicWidthLayoutResult): Deleted.
(WebCore::Layout::InlineContentCache::clearMaximumIntrinsicWidthLayoutResult): Deleted.
(WebCore::Layout::InlineContentCache::maximumIntrinsicWidthLayoutResult): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layout):
(WebCore::Layout::InlineFormattingContext::minimumMaximumContentSize):
(WebCore::Layout::InlineFormattingContext::maximumContentSize):
(WebCore::Layout::InlineFormattingContext::createDisplayContentForLineFromCachedContent):
* Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.cpp:
(WebCore::Layout::IntrinsicWidthHandler::computedIntrinsicWidthForConstraint):
(WebCore::Layout::IntrinsicWidthHandler::simplifiedMaximumWidth):
* Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.h:
(WebCore::Layout::IntrinsicWidthHandler::maximumIntrinsicWidthLineContent):
(WebCore::Layout::IntrinsicWidthHandler::maximumIntrinsicWidthResult): Deleted.

Canonical link: https://commits.webkit.org/273628@main




More information about the webkit-changes mailing list