[webkit-changes] [WebKit/WebKit] 32f6aa: REGRESSION (273506 at main): Going back to a PDF file...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 32f6aad73de0963f299af91b32f225a9c5c1d1d8
      https://github.com/WebKit/WebKit/commit/32f6aad73de0963f299af91b32f225a9c5c1d1d8
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-01-27 (Sat, 27 Jan 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm

  Log Message:
  -----------
  REGRESSION (273506 at main): Going back to a PDF file fails to render the PDF
https://bugs.webkit.org/show_bug.cgi?id=268237
rdar://121757735

Reviewed by Tim Horton.

In the refactoring in 273506 at main, the loading fallback for non-linearized PDF lost
the check of `m_incrementalPDFLoadingEnabled`. Without that, we never create the
PDF document in the fallback case, for some loading timings.

Not currently testable.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::streamDidFinishLoading):

Canonical link: https://commits.webkit.org/273614@main